Two performance improvements #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2018 14:56
- If the object being converted is already a DateTime, we can pass it directly to the RiCal DateTime constructor as-is, since that constructor already has support to skip stringifying/text parsing if a DateTime object is passed
- Checking equality via the `==` method involved a significant amount of computation - I found that the majority of the time equality was being checked, parent and timezone_finder were actually the exact same object instance - By checking for `equal?` first, we do a much simpler/faster (which is also more strict) first, allowing us to shortcut the lengthier equality comparison if the objects are actually the same instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages for details