JSONPure: String#to_json should raise on invalid encoding #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: ruby#344 This matches the ext behavior.
|
Thank you. Now that the gem is seeing active development I went to fix #344 and was pleasantly surprised to see you already addressed it. |
eregon
reviewed
Oct 21, 2024
| state = State.from_state(state) | ||
| if encoding == ::Encoding::UTF_8 | ||
| unless valid_encoding? | ||
| raise GeneratorError, "source sequence is illegal/malformed utf-8" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #344
This matches the ext behavior.