Skip to content

Remove HTML Coverage export #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ permissions:
id-token: write

env:
COVERAGE: true
K_SOUP_COV_MIN_BRANCH: 85
K_SOUP_COV_MIN_LINE: 91
K_SOUP_COV_MIN_HARD: true
K_SOUP_COV_FORMATTERS: "html,xml,rcov,lcov,json,tty"
# Removed HTML output, see: https://github.com/codecov/feedback/discussions/726#discussioncomment-13756707
K_SOUP_COV_FORMATTERS: "xml,rcov,lcov,json,tty"
K_SOUP_COV_DO: true
K_SOUP_COV_MULTI_FORMATTERS: true
K_SOUP_COV_COMMAND_NAME: "Test Coverage"
Expand Down Expand Up @@ -94,6 +96,7 @@ jobs:
# Build will fail here if coverage upload fails
# which will hopefully be noticed for the lack of code coverage comments
- name: Upload coverage to CodeCov
if: ${{ !env.ACT }}
uses: codecov/codecov-action@v5
with:
use_oidc: true
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/current.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,23 +37,23 @@ jobs:
strategy:
matrix:
include:
# Ruby 3.4
- ruby: "3.4"
# Ruby <whichever version is current, e.g., 3.4 as of 2025-07-12>
- ruby: "ruby"
appraisal_name: "r3"
exec_cmd: "rake test"
gemfile: "Appraisal.root"
rubygems: latest
bundler: latest

# truffleruby-24.1
# truffleruby <whichever version is current, e.g., 24.1 as of 2025-07-12>
- ruby: "truffleruby"
appraisal_name: "r3"
exec_cmd: "rake test"
gemfile: "Appraisal.root"
rubygems: default
bundler: default

# jruby-10.0 (targets Ruby 3.4 compatibility)
# jruby <whichever version is current, e.g., 10.0 (targets Ruby 3.4 compatibility) as of 2025-07-12>
- ruby: "jruby"
appraisal_name: "r3"
exec_cmd: "rake test"
Expand All @@ -75,7 +75,7 @@ jobs:
bundler: ${{ matrix.bundler }}
bundler-cache: false

# Raw `bundle` will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e. Appraisal.root)
# Raw `bundle` will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e., Appraisal.root)
# We need to do this first to get appraisal installed.
# NOTE: This does not use the main Gemfile at all.
- name: Install Root Appraisal
Expand Down
12 changes: 6 additions & 6 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Appraisal.root.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ source "https://rubygems.org"

gemspec

gem "appraisal", github: "pboling/appraisal", branch: "galtzo"
gem "appraisal2", github: "appraisal-rb/appraisal2", branch: "main"
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ gemspec
eval_gemfile "gemfiles/modular/debug.gemfile"

### Testing
gem "appraisal", github: "pboling/appraisal", branch: "galtzo"
gem "appraisal2", github: "appraisal-rb/appraisal2", branch: "main"

# Only runs on the latest Ruby
if current_ruby_version >= latest_ruby_version
Expand Down
23 changes: 8 additions & 15 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,18 +1,9 @@
GIT
remote: https://github.com/dashingrocket/simplecov-cobertura
revision: b72eacdeab8b055533debc6fd150cb977db0ca3e
remote: https://github.com/appraisal-rb/appraisal2
revision: 499a56ddcd75b413ed4b536ab8c0b6db47afa907
branch: main
specs:
simplecov-cobertura (2.1.1.pre.dev)
rexml
simplecov (~> 0.19)

GIT
remote: https://github.com/pboling/appraisal
revision: a3a3e4b7db67d9b085f96b2ffddd2b51bd8a1196
branch: galtzo
specs:
appraisal (3.0.0.rc1)
appraisal2 (3.0.0)
bundler (>= 1.17.3)
rake (>= 10)
thor (>= 0.14)
Expand Down Expand Up @@ -127,7 +118,7 @@ GEM
racc (1.8.1)
rainbow (3.1.1)
rake (13.3.0)
rdoc (6.14.1)
rdoc (6.14.2)
erb
psych (>= 4.0.0)
reek (6.5.0)
Expand Down Expand Up @@ -202,6 +193,9 @@ GEM
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-cobertura (2.1.0)
rexml
simplecov (~> 0.19)
simplecov-console (0.9.3)
ansi
simplecov
Expand Down Expand Up @@ -250,7 +244,7 @@ PLATFORMS
x86_64-linux

DEPENDENCIES
appraisal!
appraisal2!
benchmark (~> 0.4)
bundler-audit (~> 0.9.2)
cgi (~> 0.5.0)
Expand All @@ -272,7 +266,6 @@ DEPENDENCIES
rubocop-minitest (~> 0.36)
rubocop-packaging (~> 0.6, >= 0.6.0)
ruby-openid2!
simplecov-cobertura!
standard (~> 1.47)
stone_checksums (~> 1.0)
uri (~> 1.0, >= 1.0.3)
Expand Down
3 changes: 0 additions & 3 deletions gemfiles/modular/coverage.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,3 @@

# Coverage
# All coverage gems are listed in gemspec dependencies.
# But fix in the main branch (https://github.com/dashingrocket/simplecov-cobertura/pull/32)
# needed to prevent the circular require warning and stacktrace.
gem "simplecov-cobertura", github: "dashingrocket/simplecov-cobertura", branch: "main"
Loading