feat(rewrite): #2721 prepend rtk for TOML filters invoked via binary paths.#2722
Open
denis-peshkov wants to merge 1 commit into
Open
feat(rewrite): #2721 prepend rtk for TOML filters invoked via binary paths.#2722denis-peshkov wants to merge 1 commit into
denis-peshkov wants to merge 1 commit into
Conversation
…ike `node_modules/.bin/make` that match built-in TOML filters but have no `rules.rs` prefix entry. Closes rtk-ai#2721 ## Why `run_fallback` already resolves basename for TOML lookup; `rtk rewrite` did not. Path invocations were never rewritten → no token savings in Cursor/Claude agents. ## Changes - `lookup_command_for_filter()` in `toml_filter.rs` - TOML-match fallback in `registry.rs::rewrite_segment_inner()` - Tests using existing `make` built-in filter
denis-peshkov
changed the title
rtk for commands like node_modules/.bin/make that match built-in TOML filters but have no rules.rs prefix entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TOML-aware rewrite fallback so hooks prepend
rtkfor commands likenode_modules/.bin/makethat match built-in TOML filters but have norules.rsprefix entry.After #2719
Closes #2721
Why
run_fallbackalready resolves basename for TOML lookup;rtk rewritedid not. Path invocations were never rewritten → no token savings in Cursor/Claude agents.Changes
lookup_command_for_filter()intoml_filter.rsregistry.rs::rewrite_segment_inner()makebuilt-in filter