fix(cursor): #2719 handle rtk rewrite exit code 3 in preToolUse hook.#2720
Closed
denis-peshkov wants to merge 1 commit into
Closed
fix(cursor): #2719 handle rtk rewrite exit code 3 in preToolUse hook.#2720denis-peshkov wants to merge 1 commit into
denis-peshkov wants to merge 1 commit into
Conversation
… hook. Exit code 3 carries a rewritten command but must not be treated as failure. The previous || fallback discarded successful rewrites on every matched command.
4 tasks
Collaborator
|
Hi, thanks for your PR. A better and more complete fix is available in #2609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Cursor
preToolUsehook ignoring successfulrtk rewriteresults on exit code 3.Closes #2719
Why
rtk rewriteuses exit 3 for Default/Ask verdicts while still printing the rewritten command. The Cursor hook treated exit 3 as failure via|| { echo '{}'; exit 0; }, so rewrites were silently dropped.Changes
hooks/cursor/rtk-rewrite.sh: explicit exit-code handling (align with Claude hook)rtk-hook-version: 1 → 2