refactor: align runtime code to webpack 5.0.4#21
Merged
LingyuCoder merged 6 commits intomainfrom Mar 12, 2025
Merged
Conversation
chenjiahan
reviewed
Mar 12, 2025
Member
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
The source is webpack@5.0.4 or webpack-dev-server@5.0.4? Can we provide a link to the original code
LingyuCoder
force-pushed
the
refactor/align-client
branch
from
197732e to
18a7b51
Compare
Contributor
Author
done |
chenjiahan
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align client code with
webpack-dev-server@5.0.4. Disable biome linter to make sure the code is the same so that we can figure out the difference easily. This is helpful when we need to upgrade webpack-dev-server.index.js: https://github.com/webpack/webpack-dev-server/blob/v5.0.4/client-src/index.jsreloadApp.js: https://github.com/webpack/webpack-dev-server/blob/v5.0.4/client-src/utils/reloadApp.js