Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's development setup by eliminating the ESLint and Commitlint tools. This change simplifies the dependency tree and removes the enforcement of specific code style and commit message conventions, potentially reducing overhead in the development workflow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR removes eslint, commitlint, husky, and lint-staged from the project, simplifying the development tooling. Prettier, cspell, and TypeScript type checking remain as the lint checks.
Changes:
- Removed eslint, commitlint, husky, and lint-staged configurations and dependencies
- Updated CI workflow to remove commitlint validation and
fetch-depth: 0 - Simplified
fixandpreparescripts in package.json
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed devDependencies and scripts for eslint, commitlint, husky, lint-staged |
| eslint.config.mjs | Deleted eslint configuration |
| commitlint.config.js | Deleted commitlint configuration |
| lint-staged.config.js | Deleted lint-staged configuration |
| .husky/pre-commit | Deleted husky pre-commit hook |
| .husky/commit-msg | Deleted husky commit-msg hook |
| .github/workflows/nodejs.yml | Removed commitlint step, fetch-depth, renamed job labels |
| pnpm-lock.yaml | Removed all related package resolutions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request removes ESLint, Commitlint, Husky, and Lint-Staged from the project. While the changes correctly remove the configurations, scripts, and dependencies for these tools, this action raises significant concerns about maintaining code quality and commit message consistency. Automated linting and commit validation are crucial for collaborative projects to enforce standards, catch potential errors early, and improve overall maintainability. Removing these quality gates without a clear replacement strategy could be a critical regression for the project's health. I strongly recommend reconsidering this change unless there is a compelling reason and a plan to introduce alternative quality assurance tools.
| "fix:js": "pnpm run lint:code -- --fix", | ||
| "fix:prettier": "pnpm run lint:prettier -- --write", | ||
| "fix": "npm-run-all -l fix:js fix:prettier", | ||
| "fix": "pnpm run fix:prettier", |
There was a problem hiding this comment.
For clarity and to reduce indirection, you could define the fix script directly with the prettier command instead of aliasing fix:prettier. This makes the script's action immediately obvious. You could then also consider removing the now-redundant fix:prettier script.
| "fix": "pnpm run fix:prettier", | |
| "fix": "pnpm run lint:prettier -- --write", |
Remove eslint and commitlint