Skip to content

chore: remove eslint and commitlint#13

Merged
chenjiahan merged 1 commit intomainfrom
remoe_eslint_0314
Mar 14, 2026
Merged

chore: remove eslint and commitlint#13
chenjiahan merged 1 commit intomainfrom
remoe_eslint_0314

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Remove eslint and commitlint

Copilot AI review requested due to automatic review settings March 14, 2026 12:38
@chenjiahan chenjiahan merged commit 877b550 into main Mar 14, 2026
1 of 6 checks passed
@chenjiahan chenjiahan deleted the remoe_eslint_0314 branch March 14, 2026 12:39
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's development setup by eliminating the ESLint and Commitlint tools. This change simplifies the dependency tree and removes the enforcement of specific code style and commit message conventions, potentially reducing overhead in the development workflow.

Highlights

  • Removal of Linting and Commit Hooks: The pull request completely removes ESLint and Commitlint from the project, including their configurations and associated Husky hooks, simplifying the development environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .husky/commit-msg
    • Removed the commitlint hook.
  • .husky/pre-commit
    • Removed the lint-staged hook.
  • commitlint.config.js
    • Removed the commitlint configuration file.
  • eslint.config.mjs
    • Removed the ESLint configuration file.
  • lint-staged.config.js
    • Removed the lint-staged configuration file.
  • package.json
    • Removed 'commitlint' and 'lint:code' scripts.
    • Updated 'lint' and 'fix' scripts to reflect the removal of ESLint.
    • Removed 'husky' from the 'prepare' script.
    • Removed '@commitlint/cli', '@commitlint/config-conventional', 'eslint', 'eslint-config-webpack', 'husky', and 'lint-staged' from 'devDependencies'.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/nodejs.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes eslint, commitlint, husky, and lint-staged from the project, simplifying the development tooling. Prettier, cspell, and TypeScript type checking remain as the lint checks.

Changes:

  • Removed eslint, commitlint, husky, and lint-staged configurations and dependencies
  • Updated CI workflow to remove commitlint validation and fetch-depth: 0
  • Simplified fix and prepare scripts in package.json

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Removed devDependencies and scripts for eslint, commitlint, husky, lint-staged
eslint.config.mjs Deleted eslint configuration
commitlint.config.js Deleted commitlint configuration
lint-staged.config.js Deleted lint-staged configuration
.husky/pre-commit Deleted husky pre-commit hook
.husky/commit-msg Deleted husky commit-msg hook
.github/workflows/nodejs.yml Removed commitlint step, fetch-depth, renamed job labels
pnpm-lock.yaml Removed all related package resolutions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes ESLint, Commitlint, Husky, and Lint-Staged from the project. While the changes correctly remove the configurations, scripts, and dependencies for these tools, this action raises significant concerns about maintaining code quality and commit message consistency. Automated linting and commit validation are crucial for collaborative projects to enforce standards, catch potential errors early, and improve overall maintainability. Removing these quality gates without a clear replacement strategy could be a critical regression for the project's health. I strongly recommend reconsidering this change unless there is a compelling reason and a plan to introduce alternative quality assurance tools.

"fix:js": "pnpm run lint:code -- --fix",
"fix:prettier": "pnpm run lint:prettier -- --write",
"fix": "npm-run-all -l fix:js fix:prettier",
"fix": "pnpm run fix:prettier",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to reduce indirection, you could define the fix script directly with the prettier command instead of aliasing fix:prettier. This makes the script's action immediately obvious. You could then also consider removing the now-redundant fix:prettier script.

Suggested change
"fix": "pnpm run fix:prettier",
"fix": "pnpm run lint:prettier -- --write",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants