Skip to content

fix!: remove optimization.removeAvailableModules API#85

Merged
chenjiahan merged 1 commit intomainfrom
remove_removeAvailableModules_0317
Mar 17, 2026
Merged

fix!: remove optimization.removeAvailableModules API#85
chenjiahan merged 1 commit intomainfrom
remove_removeAvailableModules_0317

Conversation

@chenjiahan
Copy link
Member

Copilot AI review requested due to automatic review settings March 17, 2026 13:48
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the optimization configuration by removing a specific API that is no longer needed or supported. Concurrently, it updates the core Rspack dependency to a newer beta version, ensuring compatibility and leveraging the latest features and fixes.

Highlights

  • API Removal: The optimization.removeAvailableModules API has been completely removed from the configuration, its documentation, and type definitions.
  • Dependency Update: The @rspack/core dependency has been updated from 2.0.0-beta.3 to 2.0.0-beta.7, along with its associated binding packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • README.md
    • Removed removeAvailableModules from the optimization configuration section.
  • package.json
    • Updated @rspack/core dependency to 2.0.0-beta.7.
  • pnpm-lock.yaml
    • Updated lockfile entries for @rspack/core and its platform-specific binding packages to 2.0.0-beta.7.
  • src/Optimization.js
    • Removed removeAvailableModules from the list of configurable optimization properties.
  • types/index.d.ts
    • Removed the type definition for the removeAvailableModules method within the Optimization namespace.
  • types/test/rspack-chain-tests.ts
    • Removed the test case for removeAvailableModules.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chenjiahan chenjiahan merged commit b462beb into main Mar 17, 2026
9 checks passed
@chenjiahan chenjiahan deleted the remove_removeAvailableModules_0317 branch March 17, 2026 13:50
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the optimization.removeAvailableModules API. The changes are consistent across the codebase, with the API being removed from the Optimization class, its TypeScript definitions, related tests, and the README.md documentation. The @rspack/core dependency has also been updated to version 2.0.0-beta.7, which presumably contains this breaking change. The changes are correct and complete.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated/breaking optimization.removeAvailableModules chain API across implementation, TypeScript types, docs, and type tests, aligning this package with the updated @rspack/core API.

Changes:

  • Removed removeAvailableModules from the Optimization chainable API surface (implementation + .d.ts).
  • Updated docs and type-level chain tests to stop referencing the removed API.
  • Bumped @rspack/core from 2.0.0-beta.3 to 2.0.0-beta.7 (and updated lockfile).

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Optimization.js Drops removeAvailableModules from the set of generated/extended optimization chain keys.
types/index.d.ts Removes the Optimization.removeAvailableModules(...) method typing.
types/test/rspack-chain-tests.ts Updates type-chain test to no longer call .removeAvailableModules(true).
README.md Removes documentation examples/merge-shape entries referencing removeAvailableModules.
package.json Updates @rspack/core devDependency to 2.0.0-beta.7.
pnpm-lock.yaml Lockfile update reflecting the @rspack/core bump and corresponding bindings.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants