fix!: remove optimization.removeAvailableModules API#85
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the optimization configuration by removing a specific API that is no longer needed or supported. Concurrently, it updates the core Rspack dependency to a newer beta version, ensuring compatibility and leveraging the latest features and fixes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the optimization.removeAvailableModules API. The changes are consistent across the codebase, with the API being removed from the Optimization class, its TypeScript definitions, related tests, and the README.md documentation. The @rspack/core dependency has also been updated to version 2.0.0-beta.7, which presumably contains this breaking change. The changes are correct and complete.
There was a problem hiding this comment.
Pull request overview
Removes the deprecated/breaking optimization.removeAvailableModules chain API across implementation, TypeScript types, docs, and type tests, aligning this package with the updated @rspack/core API.
Changes:
- Removed
removeAvailableModulesfrom the Optimization chainable API surface (implementation +.d.ts). - Updated docs and type-level chain tests to stop referencing the removed API.
- Bumped
@rspack/corefrom2.0.0-beta.3to2.0.0-beta.7(and updated lockfile).
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Optimization.js |
Drops removeAvailableModules from the set of generated/extended optimization chain keys. |
types/index.d.ts |
Removes the Optimization.removeAvailableModules(...) method typing. |
types/test/rspack-chain-tests.ts |
Updates type-chain test to no longer call .removeAvailableModules(true). |
README.md |
Removes documentation examples/merge-shape entries referencing removeAvailableModules. |
package.json |
Updates @rspack/core devDependency to 2.0.0-beta.7. |
pnpm-lock.yaml |
Lockfile update reflecting the @rspack/core bump and corresponding bindings. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
web-infra-dev/rspack#13317