Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new react-router example to demonstrate React Server Components (RSC) Data Mode integration with Rsbuild. The changes include updating the README.md and biome.json, adding a complete new example directory with client and server entry points, route definitions, server actions, and SSR configuration. Review comments suggest improvements such as initializing entryJsFiles to an empty array to prevent potential undefined values, explicitly importing Buffer for better clarity and compatibility, removing redundant alias configurations in rsbuild.config.ts, simplifying a verbose type assertion in entry.browser.tsx, refactoring the shouldBypassRequest function for improved readability, and adding detailed explanations for @ts-expect-error suppressions to enhance code maintainability.
Rsbuild RSC React Router Example
This example shows how to run React Router's experimental RSC Data Mode on top
of
rsbuild-plugin-rsc.What It Demonstrates
unstable_matchRSCServerRequestunstable_RSCStaticRouterplus a custom Rsbuild SSRadapter that injects the React Router flight stream
unstable_RSCHydratedRouterreact-server-dom-rspackrsbuild-plugin-rscstill provides the RSC build layers and the
rsc:updatedev signal