Skip to content

chore: react router rsc data mode#27

Merged
SyMind merged 1 commit intomainfrom
react-router-example
Mar 25, 2026
Merged

chore: react router rsc data mode#27
SyMind merged 1 commit intomainfrom
react-router-example

Conversation

@SyMind
Copy link
Copy Markdown
Collaborator

@SyMind SyMind commented Mar 25, 2026

Rsbuild RSC React Router Example

This example shows how to run React Router's experimental RSC Data Mode on top
of rsbuild-plugin-rsc.

What It Demonstrates

  • React Router RSC request handling with unstable_matchRSCServerRequest
  • HTML rendering with unstable_RSCStaticRouter plus a custom Rsbuild SSR
    adapter that injects the React Router flight stream
  • Browser hydration with unstable_RSCHydratedRouter
  • React Server Actions over react-server-dom-rspack
  • Client-side navigation managed by React Router, while rsbuild-plugin-rsc
    still provides the RSC build layers and the rsc:update dev signal

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily introduces a new react-router example to showcase the integration of React Router's experimental RSC Data Mode with rsbuild-plugin-rsc. This example provides a comprehensive setup for server-side rendering, client-side hydration, and React Server Actions, illustrating how to build a full-stack application using these technologies. Additionally, it includes a minor update to the project's Biome configuration.

Highlights

  • New Example: React Router RSC Data Mode: A new example has been introduced to demonstrate the integration of React Router's experimental RSC Data Mode with rsbuild-plugin-rsc, showcasing server-side rendering, client-side hydration, and server actions.
  • Biome Configuration Update: The Biome schema version has been updated from 2.4.5 to 2.4.7.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new react-router example to demonstrate React Server Components (RSC) Data Mode integration with Rsbuild. The changes include updating the README.md and biome.json, adding a complete new example directory with client and server entry points, route definitions, server actions, and SSR configuration. Review comments suggest improvements such as initializing entryJsFiles to an empty array to prevent potential undefined values, explicitly importing Buffer for better clarity and compatibility, removing redundant alias configurations in rsbuild.config.ts, simplifying a verbose type assertion in entry.browser.tsx, refactoring the shouldBypassRequest function for improved readability, and adding detailed explanations for @ts-expect-error suppressions to enhance code maintainability.

@SyMind SyMind merged commit 7ea3b9a into main Mar 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant