Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new rspress-custom-theme skill that guides users through four levels of Rspress v2 theme customization: CSS variable overrides, BEM class overrides, Layout slots (wrap), and component ejection. The skill addresses a real gap—without it, the model consistently uses outdated v1 import paths and misses the rspress eject CLI command.
Changes:
- New
SKILL.mddefining the skill with decision-flow guidance across four customization levels - New
evals/evals.jsonwith three evaluation scenarios covering each key customization path - Benchmark workspace (
iteration-1/) with eval outputs, grading, timing, and summary files
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
skills/rspress-custom-theme/SKILL.md |
Core skill content with four-level customization guide |
skills/rspress-custom-theme/evals/evals.json |
Three eval scenarios testing CSS, slots, and eject flows |
rspress-custom-theme-workspace/iteration-1/benchmark.json |
Benchmark run results and aggregated statistics |
rspress-custom-theme-workspace/iteration-1/benchmark.md |
Benchmark summary in Markdown (template values unfilled) |
rspress-custom-theme-workspace/iteration-1/eval-*/ |
Per-eval metadata, grading, timing, and output files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the rspress-custom-theme skill. However, it misses a crucial step required by the repository's style guide. As a high-severity issue, the root README.md file must be updated to include a new section for this skill, including its name, install command (npx skills add rstackjs/agent-skills --skill rspress-custom-theme), and a description. Please add this update. Additionally, I've found several medium-severity issues in the new benchmark and evaluation files, including a hardcoded absolute path, future dates, and placeholder content. Please see the detailed comments.
Note: Security Review has been skipped due to the limited scope of the PR.
rspress-custom-theme-workspace/iteration-1/eval-2-layout-slots/with_skill/outputs/response.md
Outdated
Show resolved
Hide resolved
08ae0a9 to
228c89c
Compare
228c89c to
5912d52
Compare
|
Add this skill to related documents in Rspress website later. |


Summary
rspress-custom-themeskill for customizing Rspress v2 themesBenchmark Results
Per-Eval Breakdown
rspress/theme)rspress/theme)rspress ejectcommand, uses CSS hacksKey Findings
rspress/theme) instead of v2 (@rspress/core/theme-original) — a consistent and breaking errorrspress ejectCLI command exists and resorts to manual HomeLayout wrapping with CSS display:none hacksTest plan