fix: duplicated fast mode option - #1460
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR refactors the PegIn “Fast Mode” option rendering to avoid duplicated Flyover option cards by consolidating several template conditions into a single computed display state.
Changes:
- Replaced multiple overlapping
v-ifblocks with a singlefastModeState-driven rendering path. - Added explicit UI states for Flyover unavailability (disabled, no liquidity, no quotes, insufficient funds).
- Introduced a
FlyoverDisplayStateunion type to make the UI-state logic explicit.
Critical Issues
fastModeStaterelies onenoughAmountFlyover, which currently evaluates only the first quote; if multiple quotes exist, this can incorrectly hide Fast Mode quotes (or show an “insufficient funds” message) even when another quote would be affordable.
Suggestions
- Reformat the
FlyoverDisplayStateunion type to a multi-line union for readability/consistency. - Consider renaming
recaptchanNewTokenTime→recaptchaNewTokenTime(typo) as a follow-up (requires broader rename).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
annipi
approved these changes
Aug 13, 2026
spoletijuan
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUP-870