Change .umd.cjs dist files to .umd.js to satisfy jsdelivr
#1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication/node` mime type for (see jsdelivr/jsdelivr#18584 ), so we need to revert the extension to `.umd.js` in order that these files can be used in a browser via jsdelivr as per docs (prior to rrweb-io#1033 we shipped these as `.js`)
🦋 Changeset detectedLatest commit: 04cb195 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jun 12, 2025
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
Open
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jun 12, 2025
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
|
#1704 is probably better than this given the 'Dual Package' hazard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verdict from jsdelivr is that they are not going to change the
application/nodemime type for (see jsdelivr/jsdelivr#18584 ), so we need to revert the extension to.umd.jsin order that these files can be used in a browser via jsdelivr as per docs (prior to #1033 we shipped these as.js)