Fix event stream timeout at session level #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves timeout fix from request level (rroller#501) to session level, which is more appropriate since the session is created specifically for the Dahua client. Changes: - Add timeout=ClientTimeout(total=None) to ClientSession creation in __init__.py - Revert request-level timeout fix from client.py The session-level fix prevents the default 5-minute timeout from disconnecting infinite event streams while keeping regular API requests properly scoped. Tested in production with no timeout errors.
rroller
approved these changes
Oct 6, 2025
Contributor
Author
|
Thanks Ronnie for the merge and for making the Dahua cams in HA work.
- Richard
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves timeout fix from request level (#501) to session level, which is more appropriate since the session is created specifically for the Dahua client.
Changes
timeout=ClientTimeout(total=None)to ClientSession creation in__init__.pyclient.pyRationale
The session-level fix prevents the default 5-minute timeout from disconnecting infinite event streams while keeping regular API requests properly scoped.
Testing
Tested in production with no timeout errors.