This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Open
Conversation
Repository owner
deleted a comment from
Anti-gravitry
Nov 7, 2017
Repository owner
deleted a comment from
Anti-gravitry
Nov 7, 2017
Repository owner
deleted a comment from
Anti-gravitry
Nov 7, 2017
Repository owner
deleted a comment from
leftchest
Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple splash screen with a dark color.
It works by setting the lightweight SplashActivity as the default activity in the manifest. This way, the white screen that would be visible on slower devices when the "heavy" activity takes some time to be drawn doesn't appear and is instead replaced with a darker color.
The reason why I like this approach instead of "fancier" splash screens (the ones with a logo or loading animation) is that those make the app seem to open slower, even when they're properly implemented and the app opens just as fast as it did before.
Another reason is because it solves a more prominent problem than wanting to show the users something to look at while the program loads: it replaces the white screen that would be there otherwise and burns the eyes of those which have chosen the dark theme in the settings, hoping that their retinas would be spared.
Also, I needed another PR to finish the #Hacktoberfest challenge ^^
Screenshot: https://imgur.com/a/S8Lma
This PR can be cherry-picked and merges without conflicts with my other PR.