Add Firo support to address codec and Rosen extractor #2
+1,373
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleflm
changed the title
RaaCT0R
requested changes
Jan 6, 2026
Member
RaaCT0R
left a comment
RaaCT0R
left a comment
There was a problem hiding this comment.
Please address the GitHub action. It should successfully pass.
Make sure
- to update and include the
package-lockif you've changed anypackage.json - the
lintscript is executed. It is included in pre-commit, though you may need to run it manually now. In this case, executenpm run lintin bothadress-codecandrosen-extractorpackages, or just in the root of the repository.
packages/rosen-extractor/lib/getRosenData/firo/firoRosenExtractor.ts
Outdated
Show resolved
Hide resolved
packages/rosen-extractor/tests/getRosenData/firo/firoRosenExtractor.spec.ts
Show resolved
Hide resolved
packages/rosen-extractor/tests/getRosenData/firo/firoRpcRosenExtractor.spec.ts
Show resolved
Hide resolved
packages/rosen-extractor/tests/getRosenData/firo/firoRpcRosenExtractor.production.spec.ts
Outdated
Show resolved
Hide resolved
aleflm
pushed a commit
to navidR/utils
that referenced
this pull request
Jan 7, 2026
- Use Bitcoin approach for pasing - Remove some test cases - Remove unused axios and bs58check devDependencies - Some other minor changes
aleflm
pushed a commit
to navidR/utils
that referenced
this pull request
Jan 7, 2026
- Use Bitcoin approach for pasing - Remove some test cases - Remove unused axios and bs58check devDependencies - Some other minor changes
aleflm
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
1ec8aec to
1512a8c
Compare
aleflm
pushed a commit
to navidR/utils
that referenced
this pull request
Jan 7, 2026
- Use Bitcoin approach for pasing - Remove some test cases - Remove unused axios and bs58check devDependencies - Some other minor changes
aleflm
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
1512a8c to
33e16cf
Compare
aleflm
pushed a commit
to navidR/utils
that referenced
this pull request
Jan 8, 2026
- Use Bitcoin approach for parsing - Remove some test cases - Remove unused axios and bs58check devDependencies - Regenerate package-lock.json with npm 11.6.2 - Some other minor changes
aleflm
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
33e16cf to
13f6f7c
Compare
|
@RaaCT0R comments applied, ready for another round of reviews. |
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
6cd2496 to
7229d70
Compare
RaaCT0R
requested changes
Jan 26, 2026
RaaCT0R
requested changes
Jan 27, 2026
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
b51a14e to
824f862
Compare
RaaCT0R
approved these changes
Jan 28, 2026
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
824f862 to
2b29b8f
Compare
|
Rebased to the latest change in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the Firo blockchain into the
address-codecpackage by defining specific network constants and updating the encoder, decoder, and validator modules. These changes enable the system to correctly handle Firo addresses—supporting both P2PKH and P2SH formats—using standard Bitcoin library primitives similar to existing chain implementations.The update also extends the
rosen-extractorpackage by introducingFiroRosenExtractorandFiroRpcRosenExtractorclasses. These components are designed to parse lock transactions from serialized JSON or direct RPC responses, specifically looking forOP_RETURNmetadata to identify bridge requests and validating that assets are correctly sent to the lock address.To support these features, the PR includes new utility functions for generating Firo output scripts and parsing bridge data. The implementation is verified through comprehensive unit tests for address manipulation and transaction parsing, along with a production integration test suite for validating interactions with a Firo RPC node.