fix: do not clear blend prop from highlight
#351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added markdown highlights. * enchancement: Improve non-treesitter support(rose-pine#6) Added markdown highlight groups.
* feat: Add more highlights to nvim-cmp This should close rose-pine#36. For information sake, the colors and the arrangement is very personal, and can be subject to changes. Feel free to complete the list of supported CmpItemKind from there: https://github.com/hrsh7th/nvim-cmp/blob/main/lua/cmp/types/lsp.lua#L108 * fix: Remove subtle hl for CmpItemKinds
* fix: neogit highlight broken after #fe1974e * feat(neogit): adjust highlight contrast
- `rose-pine.functions.select_variant` -> `rose-pine.set` - `rose-pine.functions.toggle_variant` -> `rose-pine.toggle`
* refactor: palette * refactor: simplify init * chore!: rename functions - `rose-pine.functions.select_variant` -> `rose-pine.set` - `rose-pine.functions.toggle_variant` -> `rose-pine.toggle` * docs: update options * chore: update config with shared headings
This reverts commit 19fcb37.
--------- Co-authored-by: mvllow <[email protected]>
* Update readme.md Extended description for Structured Setup lazy.nvim * Update readme.md --------- Co-authored-by: mvllow <[email protected]>
The `SignAdd`, `SignChange`, and `SignDelete` are never referenced by any other highlight definitions than the previous `GitSigns` ones before this change. The isolated definitions are only left for backward compatibility.
* fix: set `background=light` if variant is "dawn" This change might fix rose-pine#321 * Update lua/rose-pine.lua * fix: restrict variants that override `&background` The other variant params are considered as if "auto"
|
Unfortunately there were issues reported with Neovide and having the blend property in there. Blend is a key that we repurposed but perhaps we should have our own name for it so we don’t have to clear it, like opacity? |
|
Sure, I have replaced the current use of |
|
I have to look into this a bit further once I get a chance. This would be a breaking change so I'd want to have a way to automatically handle the blend too. Are you using Neovide? |
sounds good. do you mean detecting whether we are in Neovide? as of this branch,
no, just a terminal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes an issue where
blendproperty was being cleared from highlight, causing transparency to stop working. It seems like that line was added by mistake.Before:
After:
