Remove Werror from test_quality_of_service. #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There really isn't a reason to hard-code it here, and this makes it match the rest of packages in this repository (and in all of ROS 2 more generally). Signed-off-by: Chris Lalancette <[email protected]>
Contributor
Author
|
CI:
|
wjwwood
approved these changes
Jun 24, 2022
Contributor
Author
|
Note that all of the warnings are because of the mis-merged ros2/rclcpp#1874 , which has now been reverted. So this is a clean CI run, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There really isn't a reason to hard-code it here, and this
makes it match the rest of packages in this repository (and
in all of ROS 2 more generally).
Signed-off-by: Chris Lalancette [email protected]