Skip to content

Conversation

@christian-rauch
Copy link
Contributor

Description

Use the credential settings in '~/.gitconfig' instead of the custom bloom configuration file in order to avoid maintaining an additional file with tokens and to avoid mapping https to ssh.

Fixes # (issue)

See ros-infrastructure/bloom#752.

Did you use Generative AI?

No.

Additional Information

@christian-rauch
Copy link
Contributor Author

@ahcorde or @cottsay: Can any of you, or someone else, review this PR?

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-rauch
Copy link
Contributor Author

CI is failing https://github.com/ros2/ros2_documentation/actions/runs/20057725702/job/57528063460?pr=5952

I think this is fixed now. Can you trigger the CI again? Sorry for asking, but I cannot trigger the CI myself.

@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Dec 12, 2025
christian-rauch and others added 3 commits December 21, 2025 01:51
Use the credential settings in '~/.gitconfig' instead of the custom bloom configuration file in order to avoid maintaining an additional file with tokens and to avoid mapping https to ssh.

Signed-off-by: Christian Rauch <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Christian Rauch <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Collaborator

ahcorde commented Dec 22, 2025

friendly ping @fujitatomoya @cottsay

1 similar comment
@ahcorde
Copy link
Collaborator

ahcorde commented Jan 8, 2026

friendly ping @fujitatomoya @cottsay

@ahcorde ahcorde merged commit 7d34d16 into ros2:rolling Jan 8, 2026
5 checks passed
mergify bot pushed a commit that referenced this pull request Jan 8, 2026
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
(cherry picked from commit 7d34d16)
mergify bot pushed a commit that referenced this pull request Jan 8, 2026
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
(cherry picked from commit 7d34d16)
mergify bot pushed a commit that referenced this pull request Jan 8, 2026
Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
(cherry picked from commit 7d34d16)
@christian-rauch christian-rauch deleted the patch-1 branch January 8, 2026 12:41
ahcorde added a commit that referenced this pull request Jan 8, 2026
(cherry picked from commit 7d34d16)

Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Christian Rauch <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
ahcorde added a commit that referenced this pull request Jan 8, 2026
(cherry picked from commit 7d34d16)

Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Christian Rauch <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
ahcorde added a commit that referenced this pull request Jan 8, 2026
(cherry picked from commit 7d34d16)

Signed-off-by: Christian Rauch <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Christian Rauch <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants