bt_navigator_***_rclcpp_node - Namespacing + NodeOptions forwarding
#5310
+29
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ros-navigation#5242 Inspired by: ros-navigation#5202 - `bt_navigator_***_rclcpp_node` now gets the same namespace of `bt_navigator` - `bt_navigator_***_rclcpp_node` now gets the same node options of `bt_navigator` (apart from node name, that is still forced to respect the pattern `bt_navigator_***_rclcpp_node` ) Signed-off-by: Patrick Roncagliolo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
|
Yeah, put that in the node_utils file in |
SteveMacenski
approved these changes
Jun 27, 2025
Moved to `nav2_ros_common/node_utils.hpp`, namespace `nav2`
|
@roncapat, your PR has failed to build. Please check CI outputs and resolve issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5242
Inspired by: #5202
AI generated software: NO
bt_navigator_***_rclcpp_nodenow gets the same namespace ofbt_navigatorbt_navigator_***_rclcpp_nodenow gets the same node options ofbt_navigator(apart from node name, that is still forced to respect the patternbt_navigator_***_rclcpp_node)For Maintainers:
backport-*.