Skip to content

add clockwise image rotation - #88

Open
gkesaev wants to merge 1 commit into
ros-drivers:masterfrom
gkesaev:rotate-image
Open

add clockwise image rotation#88
gkesaev wants to merge 1 commit into
ros-drivers:masterfrom
gkesaev:rotate-image

Conversation

@gkesaev

@gkesaev gkesaev commented Feb 24, 2021

Copy link
Copy Markdown

No description provided.

@furushchev

Copy link
Copy Markdown
Collaborator

Thank you for the contribution!
I think you can get rotated images by any degrees by combining this node and image_rotate node.
Please check the documentation:http://wiki.ros.org/image_rotate

@gkesaev

gkesaev commented Feb 25, 2021

Copy link
Copy Markdown
Author

In my case running another node was not an option, so I thought I might not be alone.
Thank you for the suggestion, I'll definitely use image_rotate in future products.

So are you interested in this feature, should I improve on anything or just close the PR?

@awesomebytes

Copy link
Copy Markdown
Member

If we were to support this I'd rather be able to rotate the image in all the available rotations from Opencv:

  cv::ROTATE_90_CLOCKWISE = 0,
  cv::ROTATE_180 = 1,
  cv::ROTATE_90_COUNTERCLOCKWISE = 2 

I see its usefulness, though. If you add that, I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants