Fix cpplint and crustify errors - #383
Open
gboeer wants to merge 2 commits into
Open
Conversation
Author
|
Just ran the pipline on my end: The errors raised by cpplint and uncrustify are gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the CI currently fails because of errors produced by ament_cpplint
In particular it seems to be unsatisfied by the include order of system and local headers in
include/usb_cam/formats/mjpeg.hpp.I changed all external C headers to system headers (I think this should be the case anyway?)
I moved the cpp header include of iostream after them. Now ament_cpplint seems to be satisfied.
Also, applied minor code refomratting as porposed by crustify.
fixes: #382