Remove unnecessary linking to component_manager.

clalancette · clalancette · commit 5b654ac35ac1 · 2025-07-10T20:41:00.000Z
These libraries are components themselves, and never
need any parts of component_manager.  So just remove
this dependency.

Signed-off-by: Chris Lalancette &lt;clalancette@gmail.com&gt;
diff --git a/phidgets_accelerometer/CMakeLists.txt b/phidgets_accelerometer/CMakeLists.txt
@@ -25,7 +25,6 @@ target_link_libraries(phidgets_accelerometer PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_analog_inputs/CMakeLists.txt b/phidgets_analog_inputs/CMakeLists.txt
@@ -25,7 +25,6 @@ target_link_libraries(phidgets_analog_inputs PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_analog_inputs
diff --git a/phidgets_analog_outputs/CMakeLists.txt b/phidgets_analog_outputs/CMakeLists.txt
@@ -28,7 +28,6 @@ target_link_libraries(phidgets_analog_outputs PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_analog_outputs
diff --git a/phidgets_digital_inputs/CMakeLists.txt b/phidgets_digital_inputs/CMakeLists.txt
@@ -25,7 +25,6 @@ target_link_libraries(phidgets_digital_inputs PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_digital_inputs
diff --git a/phidgets_digital_outputs/CMakeLists.txt b/phidgets_digital_outputs/CMakeLists.txt
@@ -27,7 +27,6 @@ target_link_libraries(phidgets_digital_outputs PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_digital_outputs
diff --git a/phidgets_gyroscope/CMakeLists.txt b/phidgets_gyroscope/CMakeLists.txt
@@ -29,7 +29,6 @@ target_link_libraries(phidgets_gyroscope PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_high_speed_encoder/CMakeLists.txt b/phidgets_high_speed_encoder/CMakeLists.txt
@@ -27,7 +27,6 @@ target_link_libraries(phidgets_high_speed_encoder PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_magnetometer/CMakeLists.txt b/phidgets_magnetometer/CMakeLists.txt
@@ -25,7 +25,6 @@ target_link_libraries(phidgets_magnetometer PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_motors/CMakeLists.txt b/phidgets_motors/CMakeLists.txt
@@ -27,7 +27,6 @@ target_link_libraries(phidgets_motors PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_motors
diff --git a/phidgets_spatial/CMakeLists.txt b/phidgets_spatial/CMakeLists.txt
@@ -29,7 +29,6 @@ target_link_libraries(phidgets_spatial PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_stepper/CMakeLists.txt b/phidgets_stepper/CMakeLists.txt
@@ -31,7 +31,6 @@ target_link_libraries(phidgets_stepper PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
   sensor_msgs::sensor_msgs_library
 )
 
diff --git a/phidgets_temperature/CMakeLists.txt b/phidgets_temperature/CMakeLists.txt
@@ -25,7 +25,6 @@ target_link_libraries(phidgets_temperature PUBLIC
   phidgets_api::phidgets_api
   rclcpp::rclcpp
   rclcpp_components::component
-  rclcpp_components::component_manager
 )
 
 rclcpp_components_register_nodes(phidgets_temperature

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ target_link_libraries(phidgets_accelerometer PUBLIC`
`25`	`25`	`phidgets_api::phidgets_api`
`26`	`26`	`rclcpp::rclcpp`
`27`	`27`	`rclcpp_components::component`
`28`		`- rclcpp_components::component_manager`
`29`	`28`	`sensor_msgs::sensor_msgs_library`
`30`	`29`	`)`
`31`	`30`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ target_link_libraries(phidgets_analog_outputs PUBLIC`
`28`	`28`	`phidgets_api::phidgets_api`
`29`	`29`	`rclcpp::rclcpp`
`30`	`30`	`rclcpp_components::component`
`31`		`- rclcpp_components::component_manager`
`32`	`31`	`)`
`33`	`32`
`34`	`33`	`rclcpp_components_register_nodes(phidgets_analog_outputs`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ target_link_libraries(phidgets_digital_outputs PUBLIC`
`27`	`27`	`phidgets_api::phidgets_api`
`28`	`28`	`rclcpp::rclcpp`
`29`	`29`	`rclcpp_components::component`
`30`		`- rclcpp_components::component_manager`
`31`	`30`	`)`
`32`	`31`
`33`	`32`	`rclcpp_components_register_nodes(phidgets_digital_outputs`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ target_link_libraries(phidgets_gyroscope PUBLIC`
`29`	`29`	`phidgets_api::phidgets_api`
`30`	`30`	`rclcpp::rclcpp`
`31`	`31`	`rclcpp_components::component`
`32`		`- rclcpp_components::component_manager`
`33`	`32`	`sensor_msgs::sensor_msgs_library`
`34`	`33`	`)`
`35`	`34`