Skip to content

Conversation

@Demonmasterlqx
Copy link

@Demonmasterlqx Demonmasterlqx commented Nov 17, 2025

feature: add support for prefixed joint names in joint_trajectory_controller for chainable controllers situation

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2025

@Demonmasterlqx, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to jazzy, but it must be in master
to have these changes reflected into new distributions.

@Demonmasterlqx
Copy link
Author

Sorry for that but I don't have the develop environment for the master branch.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the exact problem with chained controllers, but I'm not sure if fixing every controller is the way to go.
An alternative would be the remap feature from
ros-controls/ros2_control#1667
or a redesign of the chained controllers' interface namings.

@Demonmasterlqx
Copy link
Author

A full redesign seems like the optimal long-term solution for a future version. However, this PR offers a perfectly viable solution for the current version. Could you please share if there are any existing plans or design specifications for that future implementation?

@christophfroehlich
Copy link
Member

There is no solution for that yet. I put that on the agenda of the next PMC meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants