Add Dynamic Interface Group Values message #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
arne48,
bmagyar,
christophfroehlich,
livanov93,
mcbed and
moriarty
christophfroehlich
requested changes
Nov 14, 2024
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
"Component" is the plugin we load.
The official naming is "interface group", see here.
Is DynamicInterfaceGroupValues meaningful and not too long maybe? component_names -> interface_group_names?
Contributor
Author
|
Yes, component could be somehow confusing (I couldn't find better name that would be generic), interface group is ok for me. |
Wiktor-99
changed the title
saikishor
approved these changes
Nov 15, 2024
Member
|
@christophfroehlich should we backport this to Humble? |
Member
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 0b9753e) # Conflicts: # control_msgs/CMakeLists.txt
bmagyar
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interface for gpio controller added in ros-controls/ros2_controllers#1251