[interpreter] fix CLANG_CMAKE_DIR for Clad with builtin_llvm=OFF - #23379
Merged
Merged
Conversation
ferdymercury
force-pushed
the
patch-20
branch
from
September 16, 2026 07:26
9a62a6c to
efc67fc
Compare
ferdymercury
changed the title
but builtin_clang=ON. Otherwise Clad raises a configure error.
ferdymercury
force-pushed
the
patch-20
branch
from
September 16, 2026 07:27
efc67fc to
351e643
Compare
2 tasks
Test Results 21 files 21 suites 3d 3h 23m 36s ⏱️ For more details on these failures, see this check. Results for commit c7eeb63. ♻️ This comment has been updated with latest results. |
vgvassilev
approved these changes
Sep 17, 2026
vgvassilev
left a comment
vgvassilev
left a comment
Member
There was a problem hiding this comment.
LGMT but let's wait for @hahnjo and @guitargeek for a week before moving forward.
guitargeek
requested changes
Sep 21, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Looks almost good to me! I think we're just missing a ${LLVM_LIBDIR_SUFFIX} (see inline comment).
Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
Collaborator
Author
|
CI failures seem unrelated |
ferdymercury
added
the
skip code analysis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but builtin_clang=ON
Fixes #23378