[tree,hist] do not silently hide sqrt of negative value in T(Tree)Formula#22756
Open
ferdymercury wants to merge 2 commits into
Open
[tree,hist] do not silently hide sqrt of negative value in T(Tree)Formula#22756ferdymercury wants to merge 2 commits into
ferdymercury wants to merge 2 commits into
Conversation
return nan instead of sqrt(abs(value)) Fixes root-project#22755 Was like that since the early beginnigns https://github.com/root-project/root/blame/dd588ebc2c01182af573ea9ac7ce2ddcbc734b6e/treeplayer/src/TTreeFormula.cxx
return nan instead of sqrt(abs(value)) for consistency with TTreeFormula
ferdymercury
requested review from
guitargeek,
hageboeck,
jblomer and
pcanal
as code owners
ferdymercury
changed the title
Test Results 23 files 23 suites 3d 11h 59m 49s ⏱️ For more details on these failures, see this check. Results for commit 85307bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return nan instead of sqrt(abs(value))
Fixes #22755
Was like that since the early beginnigns https://github.com/root-project/root/blame/dd588ebc2c01182af573ea9ac7ce2ddcbc734b6e/treeplayer/src/TTreeFormula.cxx