[hist] Check arguments in axis constructors #19483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 9h 15m 16s ⏱️ For more details on these failures, see this check. Results for commit f3796f3. ♻️ This comment has been updated with latest results. |
jblomer
approved these changes
Aug 1, 2025
ferdymercury
reviewed
Aug 1, 2025
| /// \param[in] enableFlowBins whether to enable underflow and overflow bins | ||
| RVariableBinAxis(std::vector<double> binEdges, bool enableFlowBins = true) | ||
| : fBinEdges(std::move(binEdges)), fEnableFlowBins(enableFlowBins) | ||
| { | ||
| // FIXME: should validate that fBinEdges is sorted | ||
| if (fBinEdges.size() < 2) { | ||
| throw std::invalid_argument("must have >= 2 edges"); |
There was a problem hiding this comment.
Suggested change
| throw std::invalid_argument("must have >= 2 edges"); | |
| throw std::invalid_argument("must have >= 2 edges, but has " + std::to_string(fBinEdges.size())); |
| /// \param[in] enableFlowBins whether to enable underflow and overflow bins | ||
| RRegularAxis(std::size_t numNormalBins, double low, double high, bool enableFlowBins = true) | ||
| : fNumNormalBins(numNormalBins), fLow(low), fHigh(high), fEnableFlowBins(enableFlowBins) | ||
| { | ||
| // FIXME: should validate numNormalBins > 0 and low < high | ||
| if (numNormalBins == 0) { | ||
| throw std::invalid_argument("numNormalBins must be > 0"); |
There was a problem hiding this comment.
Suggested change
| throw std::invalid_argument("numNormalBins must be > 0"); | |
| throw std::invalid_argument("numNormalBins=" + std::to_string(numNormalBins) + " must be > 0"); |
There was a problem hiding this comment.
I don't think we need this: numNormalBins is unsigned, so the only value that triggers this exception is 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also test
ComputeLinearizedIndexexactly on the edges (this already worked since #19334).