[CMake] Avoid installing unneeded files with gnuinstall=OFF
#19473
Conversation
guitargeek
added
in:Build System
clean build
| if(NOT gnuinstall) | ||
| install(DIRECTORY gdml/ DESTINATION geom/gdml | ||
| FILES_MATCHING PATTERN "*.py" | ||
| PATTERN "inc" EXCLUDE | ||
| PATTERN "src" EXCLUDE) | ||
| endif() |
There was a problem hiding this comment.
It looks good in principle, but do we know where these scripts are used, if at all? What purpose do they serve being only available in the build directory? I guess it would only be fine if they were used in some tests alone and they're not supposed to be exposed to users.
There was a problem hiding this comment.
I don't know. Maybe @agheata has an idea?
There was a problem hiding this comment.
What purpose do they serve being only available in the build directory?
This is not how I read the install invocation. I read it as installing this file 'only' in the install directory (and not in the build directory) but .... only if not using the gnuinstall layout.
but do we know where these scripts are used, if at all?
We don't know if they are used. However according to the doc geom/gdml/doc/index.md those are used to convert TGeo objects to gdml from python.
So if anything it is surprising that they are not installed in all cases. In a related observation they are not tested by ctest at the moment ... Maybe Witek has some left over tests?
Test Results 21 files 21 suites 3d 15h 56m 22s ⏱️ Results for commit 6985d73. ♻️ This comment has been updated with latest results. |
The geometry packages put some almost 20 year old scripts into the
install prefix:
```txt
geom/
└── gdml
├── doc
├── ROOTwriter.py
└── writer.py
```
It's not clear why they should be there, and they are already excluded
when building ROOT with `gnuinstall=ON`. For more consistent builds
between the different options, I think it's better if this is never
installed.
This was still relevant for the external `roottest` builds, but since that project was absorbed into ROOT itself, there is not need for these files anymore.
guitargeek
force-pushed
the
gnuinstall_makefile
branch
from
7fe8b57 to
6985d73
Compare
More detail in the commit descriptions.