Skip to content

Lift xarray pin #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Lift xarray pin #437

wants to merge 5 commits into from

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jun 23, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)

What kind of change does this PR introduce?:

  • Lifts the xarray pin for compatible xesmf
  • Raises the base pandas version
  • Adjusts the Makefile to work better with tox
  • Adds a default output engine to ops outputs
  • Removes several obsolete pytest.mark.xfail markers

Does this PR introduce a breaking change?:

Somewhat. This PR adds a default output engine for nc/netcdf files (h5netcdf). This works better for most cases (i.e. better thread safety), except for instances where the metadata contains badly-encoded strings.

Other information:

pydata/xarray#7794
pydata/xarray#8821

@Zeitsperre Zeitsperre requested a review from cehbrecht June 23, 2025 14:12
@Zeitsperre Zeitsperre self-assigned this Jun 23, 2025
@Zeitsperre Zeitsperre added the dependencies Pull requests that update a dependency file label Jun 23, 2025
…etcdf when writing out netcdf files, remove some pytest.mark.xfail warnings
@coveralls
Copy link

coveralls commented Jun 23, 2025

Pull Request Test Coverage Report for Build 15830001967

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 87.024%

Totals Coverage Status
Change from base Build 15824994976: 0.02%
Covered Lines: 3105
Relevant Lines: 3568

💛 - Coveralls

@cehbrecht
Copy link
Collaborator

@Zeitsperre does regridding work now with the latest xesmf/xarray version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants