-
-
Notifications
You must be signed in to change notification settings - Fork 305
Update /gamelist/export to generate a correct Batocera gamelist.xml #2720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vargash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve the gamelist.xml export to better match the Batocera format. The changes include adding new media types (wheel, box2d_back), fixing path generation for covers, and adding an option to use local paths.
The implementation is mostly correct, but I've found a few issues:
- There's a minor bug in
ss_handler.pywherebox2d_backmedia is saved to the wrong directory. - In
gamelist_exporter.py, some media types (miximage,physical,title_screen) are not correctly referenced fromss_metadata, which will result in them being omitted from the exported XML. - The example configuration file
config.example.ymlcontains a typo for a new media type that would cause an error if used.
I've left specific comments with suggestions to fix these issues. Once they are addressed, this PR will be a great improvement to the gamelist export functionality.
gantoine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good so far, need to double-check wheel and box-2d-back from the screenscraper response
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the /gamelist/export endpoint to generate a Batocera-compatible gamelist.xml. The changes include adding support for new media types, fixing path generation, and introducing an option for local path exports. The implementation is solid and directly addresses the goals outlined in the description. I've identified a couple of areas where code duplication can be reduced to improve maintainability and have provided suggestions for refactoring. Overall, these are valuable improvements.
Description
Updated mediatypes and logic for the /gamelist/export API to try and generate a Batocera-like gamelist.xml.
The aim is to use RomM as the central owner of all the metadata, generating gamelist.xml ready to feed to Batocera/ES.
Main changes are:
Checklist
Please check all that apply.
Screenshots