Feature branch Attesteer System WIP #173
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @randygrok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant changes to support multi-validator functionality and improve the attestation system within Rollkit. It includes new testing infrastructure for multi-validator scenarios, refactors how validator hashes are handled during block conversion, and updates the RPC layer to expose a full validator set. These changes lay crucial groundwork for a more robust and decentralized block finalization process.
Highlights
- Multi-Validator Testing: I've added a new comprehensive test file (
modules/rollkitmngr/keeper/rollkit_block_test.go) that simulates multi-validator block production, commit signing, and light client verification. This includes a scenario demonstrating asynchronous validator signatures, which is crucial for the 'Attesteer System'. - Validator Hash Handling Refactor: I've refactored the
ToABCIBlockfunction inpkg/cometcompat/convert.goto no longer compute the validator hash internally. Instead, it now expects theValidatorHashto be pre-computed and available directly within theSignedHeader. This streamlines the block conversion process. - Dynamic Validator Set Support: The
ValidatorsRPC endpoint inpkg/rpc/core/consensus.gohas been updated to return all configured genesis validators, rather than a single hardcoded one. This is a foundational change for supporting dynamic or multi-validator sets. - Validator Hasher Integration: I've introduced a new
ValidatorHasherfunction inpkg/adapter/store.goand integrated it into the Rollkit node setup (server/start.go). This provides the node with a mechanism to retrieve the current validator set hash from the store's state, supporting the refactored validator hash handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces multi-validator support and attestation features. However, there are critical compilation errors due to mismatched function signatures for cometcompat.ToABCIBlock. Additionally, consider improving context handling and removing debug statements.
| cometBlock, err := cometcompat.ToABCIBlock(&cometCompatBlock, data, lastCommit, valSet) | ||
| require.NoError(t, err, "Failed to convert to CometBFT block for block %d", i+1) |
There was a problem hiding this comment.
The cometcompat.ToABCIBlock function is called with four arguments, but its definition in pkg/cometcompat/convert.go expects only three. This discrepancy will lead to a compilation error. Ensure the function call matches the function definition.
| @@ -256,7 +256,7 @@ func signBlock(t *testing.T, header types.Header, data *types.Data, privKey cryp | |||
| Signature: types.Signature(make([]byte, 64)), | |||
| } | |||
|
|
|||
| abciBlock, err := cometcompat.ToABCIBlock(tempSignedHeader, data, tempCommit) | |||
| abciBlock, err := cometcompat.ToABCIBlock(tempSignedHeader, data, tempCommit, nil) // todo (Alex): set correct valset | |||
There was a problem hiding this comment.
The cometcompat.ToABCIBlock function is called with four arguments, but its definition in pkg/cometcompat/convert.go expects only three. This will cause a compilation error. Correct the function call to match the definition.
|
|
||
| func ValidatorHasher(store *Store) func() (rollkittypes.Hash, error) { | ||
| return func() (rollkittypes.Hash, error) { | ||
| s, err := store.LoadState(context.Background()) |
There was a problem hiding this comment.
Using context.Background() here prevents cancellation or timeouts. Consider using a context passed from the caller to allow for better control over the operation's lifecycle.
|
|
||
| hash := s.Validators.Hash() | ||
|
|
||
| fmt.Printf("validator hash: %x\n", hash) |
There was a problem hiding this comment.
The fmt.Printf statement seems to be a debugging artifact. Remove it or replace it with structured logging using a logger instance for production code.
Overview