Skip to content

Feature branch Attesteer System WIP #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

randygrok
Copy link
Contributor

Overview

Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @randygrok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant changes to support multi-validator functionality and improve the attestation system within Rollkit. It includes new testing infrastructure for multi-validator scenarios, refactors how validator hashes are handled during block conversion, and updates the RPC layer to expose a full validator set. These changes lay crucial groundwork for a more robust and decentralized block finalization process.

Highlights

  • Multi-Validator Testing: I've added a new comprehensive test file (modules/rollkitmngr/keeper/rollkit_block_test.go) that simulates multi-validator block production, commit signing, and light client verification. This includes a scenario demonstrating asynchronous validator signatures, which is crucial for the 'Attesteer System'.
  • Validator Hash Handling Refactor: I've refactored the ToABCIBlock function in pkg/cometcompat/convert.go to no longer compute the validator hash internally. Instead, it now expects the ValidatorHash to be pre-computed and available directly within the SignedHeader. This streamlines the block conversion process.
  • Dynamic Validator Set Support: The Validators RPC endpoint in pkg/rpc/core/consensus.go has been updated to return all configured genesis validators, rather than a single hardcoded one. This is a foundational change for supporting dynamic or multi-validator sets.
  • Validator Hasher Integration: I've introduced a new ValidatorHasher function in pkg/adapter/store.go and integrated it into the Rollkit node setup (server/start.go). This provides the node with a mechanism to retrieve the current validator set hash from the store's state, supporting the refactored validator hash handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces multi-validator support and attestation features. However, there are critical compilation errors due to mismatched function signatures for cometcompat.ToABCIBlock. Additionally, consider improving context handling and removing debug statements.

Comment on lines +257 to +258
cometBlock, err := cometcompat.ToABCIBlock(&cometCompatBlock, data, lastCommit, valSet)
require.NoError(t, err, "Failed to convert to CometBFT block for block %d", i+1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The cometcompat.ToABCIBlock function is called with four arguments, but its definition in pkg/cometcompat/convert.go expects only three. This discrepancy will lead to a compilation error. Ensure the function call matches the function definition.

@@ -256,7 +256,7 @@ func signBlock(t *testing.T, header types.Header, data *types.Data, privKey cryp
Signature: types.Signature(make([]byte, 64)),
}

abciBlock, err := cometcompat.ToABCIBlock(tempSignedHeader, data, tempCommit)
abciBlock, err := cometcompat.ToABCIBlock(tempSignedHeader, data, tempCommit, nil) // todo (Alex): set correct valset

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The cometcompat.ToABCIBlock function is called with four arguments, but its definition in pkg/cometcompat/convert.go expects only three. This will cause a compilation error. Correct the function call to match the definition.


func ValidatorHasher(store *Store) func() (rollkittypes.Hash, error) {
return func() (rollkittypes.Hash, error) {
s, err := store.LoadState(context.Background())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using context.Background() here prevents cancellation or timeouts. Consider using a context passed from the caller to allow for better control over the operation's lifecycle.


hash := s.Validators.Hash()

fmt.Printf("validator hash: %x\n", hash)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fmt.Printf statement seems to be a debugging artifact. Remove it or replace it with structured logging using a logger instance for production code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants