[Experiment]: network commits #162

alpe · 2025-06-25T15:02:22Z

🚧 Experimental - sharing code only

coderabbitai · 2025-06-25T15:02:45Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Summary of Changes

Hello @alpe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an experimental network module designed to manage validator attestations and epoch-based soft confirmation of blocks. It significantly refactors the core Adapter component to support a flexible block event publishing mechanism, allowing events to be conditionally released based on the network module's soft confirmation status. This change aims to lay the groundwork for more advanced consensus and finality features by enabling a "soft finality" layer where blocks are only considered fully confirmed after a certain validator quorum has attested to them.

Highlights

New network module: A new Cosmos SDK module is introduced to manage validator attestations, epoch transitions, and soft confirmation of blocks.
Soft Confirmation Mechanism: Implemented a new "soft confirmation" logic in the Adapter that queues block commit events and only publishes them when a configurable condition (e.g., quorum from the network module) is met.
Adapter Refactoring: The Adapter's constructor is refactored to use functional options, improving configurability for metrics and block filtering.
CLI and gRPC Interfaces: The new network module exposes comprehensive CLI and gRPC query and transaction interfaces for interacting with its state and functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

alpe · 2025-06-25T15:03:34Z

modules/network/keeper/keeper.go

+	return k.CommitSignatures.Has(ctx, collections.Join(height, validatorAddr))
+}
+
+func (k Keeper) GetCommits(ctx sdk.Context, height int64) (*cmttypes.Commit, error) {


This returns all the commits for a height, if it is the end of an epoch.

This method does also not take into account if consensus was reached !

gemini-code-assist

Code Review

This pull request introduces significant improvements to how validator signatures are stored and retrieved, moving from raw byte storage to structured CometBFT CommitSig protobuf messages. This enhances type safety and aligns better with the underlying CometBFT data structures. The changes include updates to the Keeper and MsgServer logic, as well as corresponding test cases. Overall, the changes are well-implemented and improve the robustness of the network module. There are a few minor areas for improvement related to code clarity and potential correctness considerations for signature ordering.

gemini-code-assist · 2025-06-25T15:04:08Z

modules/network/keeper/keeper.go

+		},
+		Signatures: make([]cmttypes.CommitSig, 0),
+	}
+	// add the signatures (unordered) // todo (Alex): do we need them ordered?


The todo (Alex): do we need them ordered? comment highlights a potential correctness issue. If the order of cmttypes.CommitSig within cmttypes.Commit.Signatures is significant for CometBFT's validation or other processes, relying on collections.Walk might be problematic as it does not guarantee iteration order. This should be thoroughly investigated and addressed if ordering is indeed required.

Suggested change

// add the signatures (unordered) // todo (Alex): do we need them ordered?

// add the signatures (unordered) // TODO: Clarify if signature order is required for cmttypes.Commit and adjust if necessary.

tac0turtle and others added 22 commits June 23, 2025 12:10

add network module

80e1f67

Mkake compile

f30396b

Make proto-gen for network module

9f0ed22

Polish code; add tests

f41977d

Compile after merge

ff313fd

x

dafb0db

Add start flag to enable the validator network

e78d75c

Start local dev env

9cd1dd3

Do not stop chain when network consensus missed

48e0b76

Updates

c8cc207

Remove duplicate code

b0d8b28

Remove wip code

a0da8fa

Fix linter issues

1565f2c

Run go mod tidy only

0587cbe

Merge branch 'main' into alex/val_net_hack

b44531d

Remove hack/ folder

607b571

Explicit error handling

2ebf6b1

Ensure type safety

541c00e

Remove ai generated audit file

7b7c564

Start better attestation

de5155f

Test attestation happy path

880efa4

Provide network commits

4f29cf5

alpe changed the base branch from main to alex/val_net_val_sig June 25, 2025 15:02

gemini-code-assist bot reviewed Jun 25, 2025

View reviewed changes

alpe commented Jun 25, 2025

View reviewed changes

gemini-code-assist bot reviewed Jun 25, 2025

View reviewed changes

alpe force-pushed the alex/val_net_val_sig branch 2 times, most recently from 61cd975 to f48ac21 Compare June 30, 2025 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Experiment]: network commits #162

[Experiment]: network commits #162

Uh oh!

alpe commented Jun 25, 2025

Uh oh!

coderabbitai bot commented Jun 25, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

alpe Jun 25, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jun 25, 2025

Uh oh!

Uh oh!

	// add the signatures (unordered) // todo (Alex): do we need them ordered?
	// add the signatures (unordered) // TODO: Clarify if signature order is required for cmttypes.Commit and adjust if necessary.

[Experiment]: network commits #162

Are you sure you want to change the base?

[Experiment]: network commits #162

Uh oh!

Conversation

alpe commented Jun 25, 2025

Uh oh!

coderabbitai bot commented Jun 25, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

alpe Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)

alpe Jun 25, 2025 •

edited

Loading