-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Implement attestation message handling #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @alpe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the core logic for handling attestation messages within the network module. It significantly refactors the existing Attest
message handler to incorporate robust vote signature and block hash verification, leveraging a newly introduced BlockSource
interface for historical block data retrieval. The changes also refine the epoch-based attestation tracking and include comprehensive unit tests for the new functionality. This is an early, work-in-progress version laying the groundwork for secure attestation processing.
Highlights
- Attestation Message Refactoring: The
Attest
message handler has been significantly refactored into smaller, more focused helper functions (validateAttestation
,updateAttestationBitmap
,updateEpochBitmap
,verifyVote
) to improve readability and maintainability. - Vote Signature Verification: The
Attest
message now includes robust verification of the CometBFT vote signature and block hash against historical block data, ensuring the authenticity and integrity of attestations. This is handled by the newverifyVote
function. - Block Source Integration: A new
BlockSource
interface has been introduced and integrated into theKeeper
to allow fetching historical block data, which is crucial for the vote verification process. - Epoch-based Attestation Logic: The attestation process now explicitly checks that validators are attesting for the immediately preceding epoch (
GetCurrentEpoch() != votedEpoch+1
), and the epoch bitmap logic has been refined with a dedicatedupdateEpochBitmap
helper. - Enhanced Testing: A new comprehensive test suite for the
Attest
message has been added, including mocking of external dependencies like the StakingKeeper and BlockSource, to ensure the correctness of the new verification logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request implements attestation message handling, including validation, bitmap updates, and signature verification. It also adds a BlockSource interface for retrieving block data. The code includes new functions for validating attestations, updating bitmaps, and verifying votes. The changes also include adding a block source to the keeper and updating the message server to handle attestation messages.
/gemini help |
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
78dfe9e
to
e09076e
Compare
61cd975
to
f48ac21
Compare
🚧 WIP: This breaks IBC transfers test currently:
Error: No IBC denom found in balance after transfer!