Add ignorable glob support#1256
Open
EgoMoose wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
globIgnorePathssuch that it now supports gitignore-style negation: a leading!re-includes paths matched by an earlier glob. The last matching pattern in the list determines whether a path is ignored. Use\!to match a literal!at the start of a pattern.This should be backwards compatible with existing projects as opposed to adding something akin to extended globbing.
This makes it possible to do things like have a single source folder which contains both your client and server code, but be able to sync those code paths to separate locations.
You can still use existing glob ignore path functionality:
{ "name": "client-src", "globIgnorePaths": [ "**/*Server.{lua,luau}" ], "tree": { "$path": "src" } }Or you can use the new negation feature:
{ "name": "server-src", "globIgnorePaths": [ "**/*.{lua,luau}", "!**/*Server.{lua,luau}" ], "tree": { "$path": "src" } }Using these together you can do some pretty useful things when syncing:
{ "name": "example", "tree": { "$className": "DataModel", "ReplicatedStorage": { "$className": "ReplicatedStorage", "ClientSource": { "$path": "client-src.project.json" } }, "ServerScriptService": { "$className": "ServerScriptService", "ServerSource": { "$path": "server-src.project.json" } } } }