Use lossy conversion for msgpack UInt64 decode in plugin#1255
Merged
kennethloeffler merged 2 commits intoMay 29, 2026
Conversation
kennethloeffler
added
the
skip changelog
kennethloeffler
changed the title
Dekkonot
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1250.
This PR monkey patches the msgpack-luau library to lossily decode uint64 values as native Luau numbers. Once Luau natvie integers are live, we should look to make changes upstream to msgpack-luau so that it decodes 64 bit integers as native Luau integers where appropriate.