Use WeakDom::full_path_of#1185
Open
krakow10 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeakDom::full_path_ofrbx-dom#580Changes
syncback::snapshot::inst_pathto useWeakDom::full_path_of. I'm open to changing the function name before it's merged upstream.full_name_forwas what the private function it's making public was called.Lore
I wrote #580 yesterday, and today I found a bug (in other new rbx-dom code I wrote) related to not using a standardized "GetFullName" function while changing the WeakDom internals while running the Rojo tests. That also meant that I learned about this function that looks suspiciously similar to the one in my pull request.