Switcher #42
Open
Switcher #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi11
suggested changes
Oct 20, 2016
| import React, { PropTypes } from 'react'; | ||
|
|
||
| export default class Switcher extends React.Component { | ||
| static propTypes = { |
Contributor
There was a problem hiding this comment.
даваем ему сделаем внутреннее состояние isChecked и надо не забыть про componentWillReceiveProps
src/Switcher/Switcher.jsx
Outdated
| } | ||
| } | ||
|
|
||
| const styles = { |
Contributor
There was a problem hiding this comment.
Надо переслать на StyleSheet.create({})
| import StateProvider from '../StateProvider'; | ||
|
|
||
| storiesOf('Switcher', module) | ||
| .add('Switcher', () => ( |
Contributor
There was a problem hiding this comment.
добавить кейс где он без внешнего состояния переключается
| import React, { PropTypes } from 'react'; | ||
|
|
||
| export default class Switcher extends React.Component { | ||
| static propTypes = { |
Contributor
There was a problem hiding this comment.
давай добавил onChange и isDisabled
fi11
suggested changes
Oct 25, 2016
src/Switcher/Switcher.jsx
Outdated
|
|
||
| this.state = { | ||
| isChecked: props.isChecked, | ||
| isDisabled: props.isDisabled |
Contributor
There was a problem hiding this comment.
isDisabled не надо держать в стейте, достаточно получения через props
| this._onClickHandler = this._onClickHandler.bind(this); | ||
| this._onChangeHandler = this._onChangeHandler.bind(this); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
нужно добавить обновление стейта на componentWillReceiveProps
src/Switcher/Switcher.jsx
Outdated
|
|
||
| getDefaultRenderProps() { | ||
| return { | ||
| onChange: this._onChangeHandler, |
src/Switcher/Switcher.jsx
Outdated
| getDefaultRenderProps() { | ||
| return { | ||
| onChange: this._onChangeHandler, | ||
| onClick: this._onClickHandler |
Contributor
There was a problem hiding this comment.
onClick можно сразу в rendere навесить
src/Switcher/Switcher.jsx
Outdated
| const props = this.props; | ||
|
|
||
| if (!props.isDisabled) { | ||
| this.setState({ isChecked: !this.state.isChecked }); |
Contributor
There was a problem hiding this comment.
this.setState({ isChecked: !this.state.isChecked }, () => {
props.onClick && props.onClick(event);
props.onChange && props.onChange(this.state.isChecked);
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.