Fix high memory usage generating list of torrents for various operations#990
Open
omgbeez wants to merge 1 commit into
Open
Fix high memory usage generating list of torrents for various operations#990omgbeez wants to merge 1 commit into
omgbeez wants to merge 1 commit into
Conversation
omgbeez
changed the title
omgbeez
force-pushed
the
work/payload-table
branch
from
9f168fa to
8131895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In normal operation, when RDTClient is idle and no downloads (completed or otherwise) runtime memory use sits between 200Mi and 300Mi normally. Adding 10-20 NZB downloads (including completed) explodes the memory use up to about 3Gi.
After investigating, the issue is caused by the Torrent/NZB data in the main torrent information entities being materialized into memory. Many services in RDTClient work by generating full lists of torrent entities, which materialize these values, and most services don't need the Torrent/NZB payload.
This is likely a bit worse for NZBs as the data can be easily 10Mi or more per download. However, Torrents can sometimes contain large data files as well when lots of small chunks are present.
This change migrates the the Torrent/NZB payloads into their own DB table and adds multiple pathways to generate the list of entities that allows projecting more minimal shapes appropriate to each service. Payloads are dropped from those projections where they are not needed.
Based on the test case above generating 3Gi after 20 NZB, memory usage sits closer to 700Mi now.