Open
Conversation
- Use the v8 compilation pipeline from https://github.com/kuoruan/libv8 - Fix issues with v8go compatibility and changes in the V8 api
FerdinandvHagen
force-pushed
the
contribute-v8go
branch
from
2d7cd57 to
e58a792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at upgrading V8 to the latest (stable / chromium) version of 13.1.201.19.
There were a few issues in upgrading:
V8 was no longer compiling due to a combination of depot_tools being out of date, needing to use C++20, etc.
==> The v8 upgrade script is now based on the work over at https://github.com/kuoruan/libv8. This also would allow to potentially add windows in an easy way
V8GO was no longer compiling due to some changes in the V8 api and some new compatibility issues. I was able to fix all of them without any significant changes to the code basis and tests still run so I don't expect any major issues.