Skip to content

Fix(flutter_vibrate): Use flutter.compileSdkVersion to Fix Android Build#7

Draft
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
fix/flutter-vibrate-android-build-8974765139880159259
Draft

Fix(flutter_vibrate): Use flutter.compileSdkVersion to Fix Android Build#7
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
fix/flutter-vibrate-android-build-8974765139880159259

Conversation

@google-labs-jules
Copy link
Copy Markdown

This change fixes an Android build issue in the flutter_vibrate package by updating the build.gradle file to use flutter.compileSdkVersion instead of a hardcoded value. This resolves the Could not find compile target android-30 error and improves the package's compatibility with different Flutter and Android SDK versions.

Fixes #5


PR created automatically by Jules for task 8974765139880159259 started by @rodydavis

The hardcoded `compileSdkVersion` was causing build failures for users who did not have the exact Android SDK version installed.

This change updates the `build.gradle` file to use `flutter.compileSdkVersion`, which is the standard and recommended approach for Flutter plugins. This makes the plugin adapt to the `compileSdkVersion` defined by the consuming Flutter application, resolving the build error and making the package more robust against future Flutter SDK updates.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@rodydavis
Copy link
Copy Markdown
Owner

@jules looks like apply plugin: 'dev.flutter.flutter-gradle-plugin' got imported 4 times

The hardcoded `compileSdkVersion` was causing build failures for users who did not have the exact Android SDK version installed.

This change updates the `build.gradle` file to use `flutter.compileSdkVersion`, which is the standard and recommended approach for Flutter plugins. This makes the plugin adapt to the `compileSdkVersion` defined by the consuming Flutter application, resolving the build error and making the package more robust against future Flutter SDK updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_vibrate] Could not find compile target android-30

1 participant