action.nix: give generated workflows permissions: contents: read - #496
Open
JasonGross wants to merge 1 commit into
Open
action.nix: give generated workflows permissions: contents: read#496JasonGross wants to merge 1 commit into
permissions: contents: read#496JasonGross wants to merge 1 commit into
Conversation
The generated jobs only read the repository: nothing in action.nix uses GITHUB_TOKEN, and the cachix steps authenticate with their own secrets. But the workflows run on `pull_request_target`, where the token belongs to the target repository and is writable by default unless the repository owner has changed "Workflow permissions" in the repository settings. Declaring the minimum in the workflow itself makes the generated CI safe by default rather than safe-if-configured. The .github/workflows/*.yml here are `genNixActions` output; the only change to them is the two new lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9BGQT7XUuubV6C619DW4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
permissions: contents: readto every workflow generated bymkActionFromJobs.On
pull_request_target,GITHUB_TOKENbelongs to the target repository and may be writable.action.nixdoes not use it; Cachix uses separateauthToken/signingKeysecrets. The declaration therefore removes unneeded access.This updates
action.nixand regenerates eleven workflows with:nix-shell --arg do-nothing true --run genNixActionsOnly two lines change per file, confirming they were otherwise synchronized.
🤖 Generated with Claude Code
Wordsmithed by Codex.