bugfix: Fix app deletes to delete connector and mapping dependencies when deep is true#547
Merged
vscheuber merged 1 commit intorockcarver:mainfrom Feb 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bug I noticed while working on adding in IGA glossaries (since applications can have glossaries assigned to them). The bug is that when you go to delete with
deep=true, it would not end up deleting any connector or mapping dependencies, even though we already had code to handle exporting/importing connector/mapping dependencies.There is also a CLI PR that updates the CLI tests as needed. I was going to also add ApplicationOps tests here in the library since I noticed we were missing some, but I realized that would be tricky due to the fact that applications with dependencies like connectors would involve creating an RCS (which may or may not always be available for the frodo dev tenant), but it's something we should look into adding in the future so we can better catch future bugs like this.