[materialite] Adds materialite to the main issue list [1/n]#160
Open
tantaman wants to merge 2 commits intomlaw/row-versioningfrom
Open
[materialite] Adds materialite to the main issue list [1/n]#160tantaman wants to merge 2 commits intomlaw/row-versioningfrom
tantaman wants to merge 2 commits intomlaw/row-versioningfrom
Conversation
todo: - incrementally maintain kanban board - fetch a page at a time - emit normal js collections
tantaman
changed the title
This was referenced Dec 15, 2023
Collaborator
Author
|
There's a flash of stale state then current state when swapping between Kanban and List views 🤔. Need to figure this out. Probably something in the hook implementation: https://github.com/vlcn-io/materialite/blob/7702cdece6f5d37b294189a2a38517d70005265e/packages/react/src/hooks.ts#L80 Update: the stale state flash came from: d7102f1 |
This was causing flickering of false state when switching from the board to the all view. What would happen: - Board would render with kanban order - Swap to `all` would render with kanban order - effect would run, updating order - `all` would re-render with correct order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In follow up PRs:
findCreatesmethod incvr.ts. Maybe I can make this better 🤔Diff duration:
diff.mov
I almost don't believe the numbers (< 1ms diffs) but they match the notebook which uses a dataset of 1 million items: https://observablehq.com/@tantaman/materialite#benchmarking-with-materialite
Filter updates:
filter-update.mov