Skip to content

Issue 176: Reduce auto zero voltage for intake pivot to 4 volts#192

Closed
Fatblabs wants to merge 1 commit intomainfrom
Issue-176
Closed

Issue 176: Reduce auto zero voltage for intake pivot to 4 volts#192
Fatblabs wants to merge 1 commit intomainfrom
Issue-176

Conversation

@Fatblabs
Copy link
Copy Markdown
Contributor

@Fatblabs Fatblabs commented Apr 6, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the AUTO_ZERO_VOLTAGE from 8 to 4 in the IntakePivot subsystem. I have no feedback to provide.

@RobototesProgrammers
Copy link
Copy Markdown
Contributor

The reason it was 8 was because it needs to go to the retracted position quickly over the bumper and the number I tested and worked was 8 im unsure if 4 will be enough -Aarya

@markpete
Copy link
Copy Markdown
Contributor

markpete commented Apr 6, 2026

The reason it was 8 was because it needs to go to the retracted position quickly over the bumper and the number I tested and worked was 8 im unsure if 4 will be enough -Aarya

@Jetblackdragon - Concern is that this may be causing our brown outs. You're the prog lead, so it's your call whether we change this or leave it at 8. Please see the linked issue for power consumption concern details.

@Jetblackdragon
Copy link
Copy Markdown
Contributor

I read over the issue. I think we should fine tune this at dcmps or after and just wait on the merge. Im not too worried about brownouts because this shouldnt even need to be ran during matches ideally

Copy link
Copy Markdown
Contributor

@markpete markpete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by me, but you should get verbal approval from @Jetblackdragon before merging. If he disagrees, you should close this without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intake Pivot Auto-Zero Uses Stator Stall Detection; Motor Runs at 8 V Against Hard Stop

4 participants