Skip to content

iCubGrenoble01/face: increase the low-level frequency to 1 kHz #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nicogene
Copy link
Member

As per title

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Nicogene, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is designed to significantly enhance the real-time performance and responsiveness of the iCubGrenoble01 robot. It achieves this by increasing the fundamental operating frequency of its low-level control systems and adjusting related communication rates across various electronic board and motor control configurations.

Highlights

  • Low-level Frequency Increase: The period parameter in all motor control wrapper configuration files (e.g., face-mc_wrapper.xml, head-mc_wrapper.xml, left_arm-mc_wrapper.xml, etc.) has been updated from 0.01 (100 Hz) to 0.001 (1 kHz). This change directly increases the low-level control frequency for various robot parts.
  • Communication Rate Adjustments: The TXrateOfRegularROPs parameter in multiple electronics configuration files (e.g., face-eb22-j0_1-eln.xml, left_arm-eb24-j4_7-eln.xml, right_arm-eb3-j0_3-eln.xml, etc.) has been standardized to 1 from previous values like 3 or 5. Additionally, the PC104RXrate in pc104.xml has been changed from 5 to 1. These adjustments likely optimize the transmission and reception rates for regular operations, aligning with the increased frequency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the low-level frequency to 1 kHz for iCubGrenoble01. The period and rate parameters in the configuration files have been updated. There are also some extra spaces that should be removed.

@pattacini

This comment was marked as resolved.

@pattacini pattacini changed the title iCubGrenoble01: increase the low-level frequency to 1 khz iCubGrenoble01/face: increase the low-level frequency to 1 kHz Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants