Skip to content

fix: allow viewing prompt for queued jobs#629

Merged
wesm merged 2 commits intomainfrom
fix/prompt-queued-job
Apr 6, 2026
Merged

fix: allow viewing prompt for queued jobs#629
wesm merged 2 commits intomainfrom
fix/prompt-queued-job

Conversation

@wesm
Copy link
Copy Markdown
Collaborator

@wesm wesm commented Apr 6, 2026

Summary

  • TUI now allows viewing prompts for queued jobs that have stored prompts (task, fix, compact, insights job types)
  • Extended prompt-viewable condition in handlePromptKey() and prompt navigation functions (findPrevPromptableJob, findNextPromptableJob) to include JobStatusQueued when job.Prompt is non-empty
  • Regular review/range/dirty jobs that are queued are unaffected since their prompts are built at processing time

🤖 Generated with Claude Code

Jobs that store prompts at enqueue time (task, fix, compact, insights)
had viewable prompts but the TUI only checked for done/running status.
Extend the prompt-viewable condition to include queued jobs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci bot commented Apr 6, 2026

roborev: Combined Review (f43d242)

Verdict: No medium-or-higher issues found; the change looks clean based on all review outputs.

All three reviews found no issues, including the security review. The change appears to consistently extend existing prompt-view behavior to queued jobs without introducing new medium, high, or critical concerns.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

The prompt navigation (left/right arrows in prompt view and
auto-navigation after pagination) only rebuilt currentReview for
done and running jobs. Navigating to a queued stored-prompt job
would show the previous job's prompt instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci bot commented Apr 6, 2026

roborev: Combined Review (eeb480f)

Verdict: No medium-or-higher issues found; the changes look clean.

All three reviews agree the diff is correct and safe. The queued-job prompt handling appears consistent with existing TUI prompt navigation/view behavior, and no Medium, High, or Critical findings were identified.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit 3409106 into main Apr 6, 2026
8 checks passed
@wesm wesm deleted the fix/prompt-queued-job branch April 6, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant