feat(Detections): add support for Kosmos-2 #1903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My intention is to include this PR in |
SkalskiP
requested changes
Jul 25, 2025
Comment on lines
+1461
to
+1468
| kosmos_result = ( | ||
| 'An image of a small statue of a cat, with a gramophone and a man walking past in the background.', | ||
| [ | ||
| ('a small statue of a cat', (12, 35), [(0.265625, 0.015625, 0.703125, 0.984375)]), | ||
| ('a gramophone', (42, 54), [(0.234375, 0.015625, 0.703125, 0.515625)]), | ||
| ('a man', (59, 64), [(0.015625, 0.390625, 0.171875, 0.984375)]) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
do we need to take all this as input? most of that stuff is unnecessary for us
There was a problem hiding this comment.
We don't need to, but this is the data structure that KOSMOS-2's post processor returns. I personally think asking the users to enter a different data structure would introduce a layer of friction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add visualization and annotation support for Kosmos-2.
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Colab Notebook
Docs