-
-
Notifications
You must be signed in to change notification settings - Fork 63
Set Content-Type based on file extension for Azure Blob Storage #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aixasz
wants to merge
10
commits into
robinrodricks:develop
Choose a base branch
from
aixasz:feature/azure-blob-content-type-according-to-file-extension
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Set Content-Type based on file extension for Azure Blob Storage #118
aixasz
wants to merge
10
commits into
robinrodricks:develop
from
aixasz:feature/azure-blob-content-type-according-to-file-extension
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified WriteAsync to detect MIME type from blob path using _mime.TryGetContentType - Falls back to "application/octet-stream" when no mapping is found - Uses BlobUploadOptions with BlobHttpHeaders to ensure Content-Type is stored - Fixes issue where browsers download images instead of rendering inline
eadbcb7 to
71f044f
Compare
Update AWS packages
Owner
|
Looks good but can you rewrite it to not use the |
- Modified WriteAsync to detect MIME type from blob path using _mime.TryGetContentType - Falls back to "application/octet-stream" when no mapping is found - Uses BlobUploadOptions with BlobHttpHeaders to ensure Content-Type is stored - Fixes issue where browsers download images instead of rendering inline
…sion' of https://github.com/aixasz/FluentStorage into feature/azure-blob-content-type-according-to-file-extension
Switched from Microsoft.AspNetCore.StaticFiles to MimeMapping for determining MIME types in AzureBlobStorage. Updated the project dependencies and refactored code to use MimeUtility.GetMimeMapping instead of FileExtensionContentTypeProvider.
Owner
|
Hi, there have been a lot of major changes. Can you please pull the main branch into yours so it is updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue #47
Description
Sets Content-Type header on Azure blob uploads based on file extension to ensure proper browser rendering of files (e.g., images display inline instead of downloading).
Implementation: