Refactor: Correct EIP-3085 network parameter shape, propagate wallet errors, and remove transient query clients - #7
Open
mertcano wants to merge 1 commit into
Conversation
…errors, and remove transient query clients
Why
Catch blocks previously swallowed wallet failures, returning { address: null } or false which made user rejections, missing wallets, and RPC failures indistinguishable from successful control flow. The network addition hook supplied an extraneous address parameter alongside wallet_addEthereumChain, violating the EIP-3085 standard expecting a single parameter object. Transient QueryClient instances were being allocated on every render, causing unnecessary cache invalidations.
How
Updated useConnect and useAddToNetwork to throw explicit, typed Error instances upon wallet rejections, missing environments, or invalid responses so React Query can properly expose failure states. Refactored addToNetwork to send exactly one standardized chain parameter object (wallet_addEthereumChain), safely validating and normalizing RPC URLs and optional explorer links. Removed per-render query-client allocations and unneeded cache invalidations from both mutation hooks.
Security/Robustness changes
Ensures accurate observability of wallet integration errors and robust network switching behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Catch blocks previously swallowed wallet failures, returning { address: null } or false which made user rejections, missing wallets, and RPC failures indistinguishable from successful control flow. The network addition hook supplied an extraneous address parameter alongside wallet_addEthereumChain, violating the EIP-3085 standard expecting a single parameter object. Transient QueryClient instances were being allocated on every render, causing unnecessary cache invalidations.
How
Updated useConnect and useAddToNetwork to throw explicit, typed Error instances upon wallet rejections, missing environments, or invalid responses so React Query can properly expose failure states. Refactored addToNetwork to send exactly one standardized chain parameter object (wallet_addEthereumChain), safely validating and normalizing RPC URLs and optional explorer links. Removed per-render query-client allocations and unneeded cache invalidations from both mutation hooks.
Security/Robustness changes
Ensures accurate observability of wallet integration errors and robust network switching behavior.