Skip to content

Conversation

@F17HEH
Copy link

@F17HEH F17HEH commented Nov 12, 2025

Bin dates have changed so this needs to be updated to pull the new data

Summary by CodeRabbit

  • Updates
    • Updated bin collection data source for Fareham Borough Council to ensure accurate and current collection schedules.

Bin dates have changed so this needs to be updated to pull the new data
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

Walkthrough

Updated the API request parameter for Fareham Borough Council's bin collection data handler, changing the requested dataset identifier from "DomesticBinCollections" to "DomesticBinCollections2025on" to access the updated 2025 dataset.

Changes

Cohort / File(s) Change Summary
Fareham Borough Council API dataset update
uk_bin_collection/uk_bin_collection/councils/FarehamBoroughCouncil.py
Updated API request "list" parameter from "DomesticBinCollections" to "DomesticBinCollections2025on" to switch to the updated 2025 dataset

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • Issue #1696: Directly addresses the dataset switch from "DomesticBinCollections" to "DomesticBinCollections2025on" for accessing the updated bin collection data

Suggested reviewers

  • dp247

Poem

🐰 A single string, so clean and neat,
Changes data, obsolete to sweet,
Twenty-twenty-five now flows so bright,
Fareham's bins collected just right!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a parameter for Fareham Borough Council to support 2025 bin collection data, which aligns with the objective of pulling updated bin dates.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@F17HEH F17HEH changed the title Update bin collection list parameter for 2025 fix: Fareham Borough Council parameter for 2025 Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant